Convert resident tag to srkw tag - #596
Conversation
Fixes orcasound#595 Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
|
Ran this locally with a few unreviewed candidates seeded the way PODS-AI writes them, tags pre-populated with Two findings:
One thing worth deciding rather than a finding: with srkw pre-filled, answering No leaves |
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
…cas-livesystem into resident-to-srkw
|
@kauereinbold updated, please re-review. Yes PODS-AI always uses "resident" lower case today, but I updated this to use case-insensitive anyway. Thanks for the review and testing! |
There was a problem hiding this comment.
Pull request overview
This PR updates the moderator portal’s detection initialization to normalize PODS-AI-provided tags so they match OrcaHello’s current tag vocabulary, specifically preventing the legacy "resident" tag from persisting alongside the OrcaHello "srkw" workflow.
Changes:
- Adds an initialization-time tag normalization step to remove
"resident"when it is present on incoming detections. - Documents the intent of handling model-generated tag aliases in a single place (with room for future mappings).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
kauereinbold
left a comment
There was a problem hiding this comment.
Retested at the latest head with the same kind of seeded candidates as before, plus one tagged Resident and one tagged orca;whale;resident. All three points from the last round are addressed. The resident tag is stripped on load on both the candidates and detection pages, nothing preselected, and Submit stays disabled until the moderator answers. Clicking Yes gives srkw;orca;whale with no leftovers, and the capital R variant is caught by the case-insensitive check. Answering No on a resident-only candidate now leaves the tags empty. Typing resident by hand still sticks, even after clicking Yes.
One small thing: the title and description still say convert, but the code now drops the tag without adding srkw. Might be worth a quick edit so the merge history reads right.
PODS-AI pre-populates the "resident" tag, but the OrcaHello tag is "srkw", so convert the former to the latter.
Fixes #595